Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate legacy test APIs #483

Merged
merged 1 commit into from
May 9, 2019
Merged

Deprecate legacy test APIs #483

merged 1 commit into from
May 9, 2019

Conversation

chadhietala
Copy link
Contributor

@chadhietala chadhietala commented May 6, 2019 •
edited
Loading

This deprecates the moduleFor, moduleForComponent and moduleForModel APIs. This implements the deprecation section of RFC#232.

rwjblue
rwjblue reviewed May 6, 2019
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to do a deprecation RFC for this 🤔

addon-test-support/ember-qunit/legacy-2-x/module-for-component.js Outdated Show resolved Hide resolved
addon-test-support/ember-qunit/legacy-2-x/module-for-component.js Outdated Show resolved Hide resolved
@chadhietala chadhietala force-pushed the deprecate-legacy-apis branch 2 times, most recently from 2e46809 to c7987d2 Compare May 6, 2019 14:13
@chadhietala
Copy link
Contributor Author

As we discussed, these deprecations were laid out in RFC#232

@scalvert
Copy link
Contributor

scalvert commented May 6, 2019

I'm 👍 on this change. I think it's a good time to start moving apps/addons off the older APIs.

@rwjblue rwjblue merged commit c27964a into master May 9, 2019
@rwjblue rwjblue deleted the deprecate-legacy-apis branch May 9, 2019 14:59
@Turbo87
Copy link
Member

Turbo87 commented May 13, 2019

lol, I totally missed this PR but did pretty much the same thing for ember-mocha two days ago (emberjs/ember-mocha#366)

@chadhietala
Copy link
Contributor Author

@Turbo87 I was talking to @rwjblue and I think we need a deprecation RFC to remove the rest of the old APIs. Just waiting on a replacement for the waiters API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scalvert scalvert scalvert requested changes

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chadhietala @scalvert @Turbo87 @rwjblue