Fixed this.$(selector) returning cached result
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chancancode can you pull latest master and fix conflicts? Thanks! |
|
@fivetanley updated. I noticed the new build now contains the warning about ember-data. Is this expected, or am I not supposed to submit the rebuilt |
|
@chancancode one more time please. I just fixed npm on travis so hopefully the tests should run |
Existing usage of `this.$()` will continue to function the same way, while `this.$(selector)` will work similarly to `this.subject().$(selector)` but will first ensure that the subject has been rendered. Also deprecated `this.append()` in favor of its new name, `this.render()` to help better communicate its purpose. Fixes #55.
|
🤘 |
fivetanley
added a commit
that referenced
this pull request
Jun 20, 2014
Fixed `this.$(selector)` returning cached result
|
👍 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly cleaned up version of my proposal in #55 for consideration 😄
this.appendin favor ofthis.renderas discussed.this.$(...)an alias tothis.subject().$(...)but it also ensures that the subject has been rendered into the DOM.This seems to match my expectations quite nicely – my test suite is passing with this patch.
Existing usage of
this.$()will continue to function the same way, whilethis.$(selector)will work similarly tothis.subject().$(selector)butwill first ensure that the subject has been rendered.
Also deprecated
this.append()in favor of its new name,this.render()tohelp better communicate its purpose.
Fixes #55.