Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Embroider test scenario. #756

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Add Embroider test scenario. #756

merged 1 commit into from
Sep 22, 2020

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Sep 16, 2020

No description provided.

@rwjblue
Copy link
Member Author

rwjblue commented Sep 16, 2020 •
edited
Loading

The Embroider scenario will fail until embroider-build/embroider#530 is addressed. CI shows it as a stalled job, but it's basically because we never hooked Testem into QUnit so it has no clue that the tests are done (or not).

@rwjblue rwjblue mentioned this pull request Sep 16, 2020
Merged
@rwjblue
Copy link
Member Author

rwjblue commented Sep 22, 2020

Embroider 0.25.0 includes the fix mentioned above, so 🤞 CI is happy now...

@rwjblue rwjblue merged commit 57c3327 into master Sep 22, 2020
@rwjblue rwjblue deleted the embroider-test-scenario branch September 22, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rwjblue