Correct invalid QUnit imports. #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `import QUnit from 'qunit';` is _actually_ invalid. There **is no** default export from QUnit itself. The way this was working is that it has been relying on `loader.js`'s behavior when a module does not include a default export (it makes `moduleExports.default = moduleExports`).
|
@rwjblue This would be great to support upstream. I think this is possible to do without breaking compat, right? |
|
Ya, I can submit a PR for that and we can chat through it. |
|
Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
import QUnit from 'qunit';is actually invalid. There is no default export from QUnit itself. The way this was working is that it has been relying onloader.js's behavior when a module does not include a default export (it makesmoduleExports.default = moduleExports).