Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root element auto-add ordering #93

Merged
merged 2 commits into from
Sep 22, 2014

Conversation

slindberg
Copy link
Contributor

In situations where the the #ember-testing root element is not already in the testing document and the first test uses moduleForComponent, tests fail with the error:

Setup failed on root element is auto-added before moduleFor callback: Assertion Failed: Unable to add "ember-application" class to rootElement. Make sure you set rootElement to the body or an element in the body.

This is because the callback that moduleForComponent provides to moduleFor expects the root element to exist already (by calling setup on an event dispatcher).

This also fixes a failing deprecation test because of newer deprecations in 1.7.0.

rwjblue added a commit that referenced this pull request Sep 22, 2014
@rwjblue rwjblue merged commit a773872 into emberjs:master Sep 22, 2014
@rwjblue
Copy link
Member

rwjblue commented Sep 22, 2014

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants