Skip to content

Commit

Permalink
emberjs/warning-primitives
Browse files Browse the repository at this point in the history
Expose deprecation primitives

* `?disableWarnings` queryParam
* `?debugWarnings` queryParam
* `import { getWarnings, getWarningsDuringCallback } from ‘@ember/test-helpers’;`

This is a second step in allowing us to deprecate https://github.com/workmanw/ember-qunit-assert-helpers in-favor of these helpers simply being provided by default.

---

Context: This is motivated by 4.0 changes that are incompatible with the original add-on, and the time trade-off of resurrecting that add-on vs adopting its great ideas into mainline. Although users will need to upgrade their `@ember/test-helpers` + `ember-qunit` they will now get the original functionality, + async + bugfixes by default.

 I was lead down this path getting embroider working properly on `ember@canary`

---

 enables resolving emberjs/ember-string#259 amongst other related issues (basically anyone consuming ember-qunit-assert-helpers)
  • Loading branch information
stefanpenner committed Aug 3, 2021
1 parent ae7b1d4 commit a6096f0
Show file tree
Hide file tree
Showing 5 changed files with 494 additions and 109 deletions.
Loading

0 comments on commit a6096f0

Please sign in to comment.