adds new workflow file to provide release branches #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelSumner
changed the title
NullVoxPopuli
requested changes
Jun 9, 2023
.github/workflows/push-dist.yml
Outdated
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - run: npm run build # Add whatever you need to build your pacakage here |
There was a problem hiding this comment.
this is pretty close to what I'm using over here: https://github.com/NullVoxPopuli/ember-resources/blob/main/.github/workflows/push-dist.yml
but I think, because this repo is using yarn, we need these extra lines after the checkout:
https://github.com/emberjs/ember-test-helpers/blob/master/.github/workflows/ci-build.yml#L20-L21
MelSumner
commented
Jun 13, 2023
build is not needed, because it runs as a part of prepack Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
NullVoxPopuli
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged, this PR adds https://github.com/kategengler/put-built-npm-package-contents-on-branch/ which should provide a little extra confidence for folks doing new releases (especially as we add new maintainers and update packages to use the v2/embroider guidance).
Still need to confirm some of the config settings but after that I will mark it ready for review.