Add support for factoryFor #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chadhietala I suppose we can't test this properly until the other PR is merged, correct? |
rwjblue
reviewed
Dec 18, 2016
There was a problem hiding this comment.
I'd like to export Ember._FactoryForProxyMixin upstream to simplify this logic a bit. What do you think?
I was thinking something like this might work:
const Owner = (function() {
const OWNER_MIXINS = [
Ember._RegistryProxyMixin,
Ember._ContainerProxyMixin,
Ember._FactoryForProxyMixin
].filter(Boolean)
return Ember.Object.extend.apply(Ember.Object, OWNER_MIXINS);
})();| return Ember.Object.extend(Ember._RegistryProxyMixin, Ember._ContainerProxyMixin); | ||
| } else if (FACTORY_FOR && LOOKUP_FACTORY) { |
|
Given my suggestion in emberjs/ember.js#14360 (review), no changes would be needed here in ember-test-helpers. |
|
Just going to put this stuff on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep work for emberjs/ember.js#14360