-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move integration container logic to TestModule #24
Move integration container logic to TestModule #24
Conversation
LGTM |
👍 |
Move integration container logic to TestModule
Nice work - thanks @nikz 👍 |
Is this the end of |
@cibernox - Yes, and it is released in ember-qunit@0.2.11. |
@rwjblue Updated |
@cibernox You need to opt in to the new behavior by passing |
It woks now: |
Is this going to be added to the guides and documentation? (unless it's there already and I just can't find it)
I'm pretty new to Ember, and I'm glad I stumbled across this PR. It's going to be so nice not to have to include all the |
This moves the integration logic up into TestModule, so that you can specify:
And you'll be able to resolve other units in your application without adding them to
needs
.(thanks @rwjblue!)