-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure typeIn has correct key option #465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think we should use triggerKeyEvent
's logic here, is there a way to refactor things into that?
@mydea - Have you had a chance to poke at my idea of reusing |
I've pushed a commit making |
Looks like a small linting error is failing CI:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main changes here look good to me, thank you for working on it @mydea!
Oops, fixed it and also rebased on master! |
Currently, the
typeIn()
helper will only set thecharCode
option of theKeyboardEvent
. This PR also adds the correctkey
option.