Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for return type of findAll #529

Merged
merged 1 commit into from Jan 18, 2019
Merged

Fix docs for return type of findAll #529

merged 1 commit into from Jan 18, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 18, 2019

The findAll helper states that it is equivalent to running querySelectorAll but that is a lie. Tests were failing when I was doing querySelectorAll to findAll conversions as I was relying on the item method on NodeList instances.

@rwjblue rwjblue merged commit 05b2b74 into emberjs:master Jan 18, 2019
@rwjblue
Copy link
Member

rwjblue commented Jan 18, 2019

Thank you!

@rwjblue rwjblue changed the title Fix lying doc block on findAll test helper Fix docs for return type of findAll Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants