Adding constraints around naming test waiters #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalvert
changed the title
rwjblue
reviewed
Mar 16, 2020
|
@rwjblue bump. |
scalvert
force-pushed
the
waiter-label-naming
branch
from
57669f0 to
1c32503
Compare
rwjblue
reviewed
May 13, 2020
| @@ -25,6 +25,7 @@ This addon implements the design specified in [RFC 581](https://github.com/ember | |||
| - [Installation](#installation) | |||
| - [Quickstart](#quickstart) | |||
| - [buildWaiter function](#buildwaiter-function) | |||
| - [Waiter naming conventions](#waiter-naming-conventions) | |||
There was a problem hiding this comment.
Should this be down in the best practices section, with a link from here?
| @@ -59,17 +60,31 @@ that provides a number of methods. The key methods that allow you to control asy | |||
| a pair to _begin_ waiting and _end_ waiting respectively. The `beginAsync` method returns a `token`, which uniquely identifies that async operation. To mark the | |||
| async operation as complete, call `endAsync`, passing in the `token` that was returned from the prior `beginAsync` call. | |||
|
|
|||
| #### Waiter naming conventions | |||
There was a problem hiding this comment.
Can you add a link to the eslint-plugin-ember rule docs in this section too?
rwjblue
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some constrains around the naming of test waiters. Specifically, it adds a pattern (
namespace:descriptor) for test waiters in order to help identify them. Currently this is implemented as a warning, to avoid a breaking change.README changes.