Use export type to avoid broken imports when types are transpiled away
#239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Mar 11, 2021
rwjblue
changed the title
export type to avoid broken imports when types are transpiled away
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The meat of this PR is the one line change in 31317db.
To make that work though I had to upgrade prettier, which required me to reformat a lot of the repo, and upgrade ember-cli-typescript and ember-cli-babel to make sure we would get a new enough version of
@babel/plugin-transform-typescriptto handle type-only exports.The motivation for this change is that without marking these are type-only exports, the export statement ends up staying in the Javascript even though the corresponding type definitions got deleted. That mismatch is a SyntaxError when you're using a system that respects ES modules.