Fix warnings when the legacy module deprecation is triggered

[sandydoo]

DEPRECATION: When calling `deprecate` you must provide `for` in options. Missing options.for in \"ember-test-waiters-legacy-module-name\" deprecation [deprecation id: ember-source.deprecation-without-for]

DEPRECATION: When calling `deprecate` you must provide `since` in options. Missing options.since in \"ember-test-waiters-legacy-module-name\" deprecation [deprecation id: ember-source.deprecation-without-since]

This adds the required for and since options when creating the deprecation warning.

[rwjblue]

Thanks @sandydoo!

[kellyselden]

Could we get a release of this please?

[scalvert]

I didn't notice this until running the tests myself, but this fix causes a build error due to the types being mismatched.

addon/ember-test-waiters/index.ts:9:5 - error TS2345: Argument of type '{ id: string; until: string; for: string; since: string; }' is not assignable to parameter of type '{ id: string; until: string; url?: string | undefined; }'.
  Object literal may only specify known properties, and 'for' does not exist in type '{ id: string; until: string; url?: string | undefined; }'.

9     for: 'ember-test-waiters',
      ~~~~~~~~~~~~~~~~~~~~~~~~~

Specifically, it looks as though @types/ember__debug is out of date, and the type definitions for the deprecate function aren't inline with the API updates that require the for property.

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/ember__debug/index.d.ts#L71

I can fix this in this repo, but we'll need to wait for that fix before we can release.

[sandydoo]

@scalvert, shoot, sorry for letting that slip through 😞

Linking relevant PR: DefinitelyTyped/DefinitelyTyped#52397

[scalvert]

No worries, @sandydoo! Easy mistake to make, especially considering we didn't have any type checking during CI. I'm adding this not to hopefully avoid this situation in the future.

See #279

[scalvert]

I'll try to get this fixed up and released today.