Merge pull request #11787 from martndemus/deprecate-slash-namespace

[BUGFIX release] Deprecate slash for a namespace in the {{render}} helper
emberjs · Jul 17, 2015 · 080cb36 · 080cb36
2 parents 513494f + 3c81def
commit 080cb36
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/ember-routing-htmlbars/lib/keywords/render.js b/packages/ember-routing-htmlbars/lib/keywords/render.js
@@ -74,7 +74,10 @@ export default {
     }
 
     // # legacy namespace
+    let originalName = name;
     name = name.replace(/\//g, '.');
+    Ember.deprecate(`Using a slash for namespacing with the {{render}} render helper has been deprecated.
+                     Please replace "${originalName}" with "${name}" in your call to the {{render}} helper.`, !originalName.match(/\//g));
     // \ legacy slash as namespace support
 
     var templateName = 'template:' + name;

diff --git a/packages/ember-routing-htmlbars/tests/helpers/render_test.js b/packages/ember-routing-htmlbars/tests/helpers/render_test.js
@@ -552,7 +552,7 @@ QUnit.test('{{render}} works with slash notation', function() {
 
   Ember.TEMPLATES['blog.post'] = compile('{{uniqueId}}');
 
-  runAppend(view);
+  expectDeprecation(() => { runAppend(view); }, /Using a slash for namespacing/);
 
   var singletonController = container.lookup('controller:blog.post');
   equal(singletonController.uniqueId, view.$().html(), 'rendered with correct singleton controller');