Leave note about test failure

emberjs · Oct 4, 2016 · 0d270ce · 0d270ce
1 parent 3ebc946
commit 0d270ce
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 23 deletions.
diff --git a/packages/container/lib/container.js b/packages/container/lib/container.js
@@ -9,7 +9,7 @@ import { ENV } from 'ember-environment';
 import { assert, deprecate, runInDebug, isFeatureEnabled } from 'ember-metal';
 
 const CONTAINER_OVERRIDE = symbol('CONTAINER_OVERRIDE');
-export const HAS_PROXY = !!Proxy;
+export const HAS_PROXY = window && window.Proxy;
 
 /**
  A container used to instantiate and cache objects.

diff --git a/packages/ember/tests/helpers/helper_registration_test.js b/packages/ember/tests/helpers/helper_registration_test.js
@@ -1,8 +1,8 @@
-import { Controller /*, Service, inject*/} from 'ember-runtime';
+import { Controller, Service, inject } from 'ember-runtime';
 import { run } from 'ember-metal';
 import { compile } from 'ember-template-compiler';
 import {
-  //Helper,
+  Helper,
   helper,
   setTemplates,
   setTemplate
@@ -90,23 +90,24 @@ QUnit.test('Undashed helpers registered on the container can be invoked', functi
   equal(jQuery('#wrapper').text(), 'OMG|boo|ya', 'The helper was invoked from the container');
 });
 
-// QUnit.test('Helpers can receive injections', function() {
-//   setTemplate('application', compile('<div id=\'wrapper\'>{{full-name}}</div>'));
-
-//   let serviceCalled = false;
-//   boot(() => {
-//     appInstance.register('service:name-builder', Service.extend({
-//       build() {
-//         serviceCalled = true;
-//       }
-//     }));
-//     appInstance.register('helper:full-name', Helper.extend({
-//       nameBuilder: inject.service('name-builder'),
-//       compute() {
-//         this.get('nameBuilder').build();
-//       }
-//     }));
-//   });
-
-//   ok(serviceCalled, 'service was injected, method called');
-// });
+// This fails with: Assertion Failed: Attempting to lookup an injected property on an object without a container, ensure that the object was instantiated via a container.
+QUnit.skip('Helpers can receive injections', function() {
+  setTemplate('application', compile('<div id=\'wrapper\'>{{full-name}}</div>'));
+
+  let serviceCalled = false;
+  boot(() => {
+    appInstance.register('service:name-builder', Service.extend({
+      build() {
+        serviceCalled = true;
+      }
+    }));
+    appInstance.register('helper:full-name', Helper.extend({
+      nameBuilder: inject.service('name-builder'),
+      compute() {
+        this.get('nameBuilder').build();
+      }
+    }));
+  });
+
+  ok(serviceCalled, 'service was injected, method called');
+});