correctly reset container cache

emberjs · Oct 6, 2017 · de50b87 · de50b87
1 parent a20a784
commit de50b87
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/packages/container/lib/container.js b/packages/container/lib/container.js
@@ -115,10 +115,10 @@ Container.prototype = {
    @param {String} fullName optional key to reset; if missing, resets everything
   */
   reset(fullName) {
-    if (fullName !== undefined) {
-      resetMember(this, this.registry.normalize(fullName));
-    } else {
+    if (fullName === undefined) {
       resetCache(this);
+    } else {
+      resetMember(this, this.registry.normalize(fullName));
     }
   },
 
@@ -375,7 +375,8 @@ function destroyDestroyables(container) {
 
 function resetCache(container) {
   destroyDestroyables(container);
-  container.cache.dict = dictionary(null);
+  container.cache = dictionary(null);
+  container.factoryManagerCache = dictionary(null);
 }
 
 function resetMember(container, fullName) {