Merge pull request #16097 from rwjblue/remove-sync

[CLEANUP beta] Remove `sync` runloop queue.
emberjs · Jan 10, 2018 · fde777c · fde777c
2 parents 629c5a8 + 8627dfa
commit fde777c
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 55 deletions.
diff --git a/packages/ember-metal/lib/run_loop.js b/packages/ember-metal/lib/run_loop.js
@@ -2,10 +2,6 @@ import { assert, isTesting } from 'ember-debug';
 import {
   onErrorTarget
 } from './error_handler';
-import {
-  beginPropertyChanges,
-  endPropertyChanges
-} from './property_events';
 import Backburner from 'backburner';
 
 function onBegin(current) {
@@ -16,11 +12,7 @@ function onEnd(current, next) {
   run.currentRunLoop = next;
 }
 
-const backburner = new Backburner(['sync', 'actions', 'destroy'], {
-  sync: {
-    before: beginPropertyChanges,
-    after: endPropertyChanges
-  },
+const backburner = new Backburner(['actions', 'destroy'], {
   defaultQueue: 'actions',
   onBegin,
   onEnd,

diff --git a/packages/ember-metal/tests/run_loop/schedule_test.js b/packages/ember-metal/tests/run_loop/schedule_test.js
@@ -48,11 +48,6 @@ moduleFor('system/run_loop/schedule_test', class extends AbstractTestCase {
       let runLoop = run.currentRunLoop;
       assert.ok(runLoop, 'run loop present');
 
-      run.schedule('sync', () => {
-        order.push('sync');
-        assert.equal(runLoop, run.currentRunLoop, 'same run loop used');
-      });
-
       run.schedule('actions', () => {
         order.push('actions');
         assert.equal(runLoop, run.currentRunLoop, 'same run loop used');
@@ -61,11 +56,6 @@ moduleFor('system/run_loop/schedule_test', class extends AbstractTestCase {
           order.push('actions');
           assert.equal(runLoop, run.currentRunLoop, 'same run loop used');
         });
-
-        run.schedule('sync', () => {
-          order.push('sync');
-          assert.equal(runLoop, run.currentRunLoop, 'same run loop used');
-        });
       });
 
       run.schedule('destroy', () => {
@@ -74,7 +64,7 @@ moduleFor('system/run_loop/schedule_test', class extends AbstractTestCase {
       });
     });
 
-    assert.deepEqual(order, ['sync', 'actions', 'sync', 'actions', 'destroy']);
+    assert.deepEqual(order, ['actions', 'actions', 'destroy']);
   }
 
   ['@test makes sure it does not trigger an autorun during testing']() {

diff --git a/packages/ember-metal/tests/run_loop/sync_test.js b/packages/ember-metal/tests/run_loop/sync_test.js