Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Params broken with ObjectController on 1.11.0-beta.5 #10733

Closed
craigteegarden opened this issue Mar 26, 2015 · 0 comments · Fixed by #10736
Closed

Query Params broken with ObjectController on 1.11.0-beta.5 #10733

craigteegarden opened this issue Mar 26, 2015 · 0 comments · Fixed by #10736

Comments

@craigteegarden
Copy link
Contributor

Query params seem to not work correctly on Ember 1.11.0-beta.5 when using an ObjectController. The exact code functions when using Ember 1.10.0 or when using 1.11.0-beta.5 with the ObjectController replaced with a Controller.

When binding the query param property on the controller to an input in the template, editing the text field doesn't update the URL, but setting the URL manually does update the text field.

App.IndexController = Ember.ObjectController.extend({
  queryParams: ['category'],
  category: null
})
  <script type="text/x-handlebars" data-template-name="index">
    <span>Category: {{input value=category}}</span>
  </script>

Examples:

I know ObjectController is deprecated, but if I understand the deprecation/Ember 2.0 strategy correctly, everything should still work correctly even if I still use ObjectController?

craigteegarden added a commit to craigteegarden/ember.js that referenced this issue Mar 26, 2015
rwjblue added a commit that referenced this issue Mar 26, 2015
…sion-object-controller

[BUGFIX beta] fix broken query params on ObjectController fixes #10733
rwjblue pushed a commit that referenced this issue Mar 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants