Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Rendering into wrong outlet when hijacking renderTemplate and using this.render() #10916

Closed
alexdiliberto opened this issue Apr 21, 2015 · 12 comments

Comments

@alexdiliberto
Copy link
Contributor

This one can be pooled into all of the other recent issues around rendering for v1.11.

I'm hijacking renderTemplate on all the routes and manually rendering into outlets and named outlets with nested children involved. The nested child route for both resources is rendering into the main outlet rather than their respective parent outlets.

Kind of a weird issue to describe...my description probably doesn't do it justice, so just check out the JSBins side by side.

v1.10 - Working
http://jsbin.com/qupekatuyu/2/edit?html,js,output

v1.11 - Broken
http://emberjs.jsbin.com/pidituqufu/1/edit?html,js,output

/cc @ef4

@alexdiliberto
Copy link
Contributor Author

Any information here?

@alexdiliberto
Copy link
Contributor Author

👊

Noting that this is still an ongoing issue in the latest release of Ember v1.13.4

@ef4
Copy link
Contributor

ef4 commented Jul 14, 2015

You are probably right that there is a regression here, but this bug has been stuck at low priority because it seems to affect a very tiny slice of actual apps. We are three major releases in, with a single bug report.

There were a lot of underspecified corner cases in the old implementation, and we have tried to fix as many as is practical. I would like to fix this one too, but haven't found the time.

@jcope2013
Copy link
Contributor

bumped into issue today in my app also on 1.13.5 as i jumped from 1.9

updated the jsbin in #10652 to latest version and seeing same issue

http://emberjs.jsbin.com/qucuragaxu/edit?html,css,js,output

changing my nested route renderTemplate from this

 renderTemplate: function(){
    this.render({outlet: 'fullPage'});
  }

to this

renderTemplate: function(){
    this.render({into: 'application', outlet: 'fullPage'});
  }

seems to be working at moment

@alexdiliberto
Copy link
Contributor Author

@jcope2013 Glad I'm not the only one who is having this issue, but I looked at your example workaround and couldn't get it working with my original broken JSin

@jcope2013
Copy link
Contributor

@alexdiliberto this seems to fix it? or make it act more like the 1.10 version which has other bugs http://emberjs.jsbin.com/rihifakimo/1/edit?html,js,output

i removed in the transfers route

this.render('accounts', { into: 'application' });

@alexdiliberto
Copy link
Contributor Author

@jcope2013 Yea still not the same unfortunately by removing that render block...now the transition looks messed up. Hopefully this issue will be fixed.

@locks
Copy link
Contributor

locks commented Apr 18, 2016

@ef4 @jcope2013 @alexdiliberto is this still happening?

@jcope2013
Copy link
Contributor

@locks yes tried on ember 2.5 and still have to use workaround mentioned in #10916 (comment) or it doesn't work properly

@Serabe
Copy link
Member

Serabe commented Jul 22, 2016

This issue is still happening in 2.6.2. In beta still looks like:

2016-07-22 at 19 01

While in 1.10 it looked like:

2016-07-22 at 19 02

@Serabe
Copy link
Member

Serabe commented Apr 16, 2017

Still happening in 2.12. Moved it to this twiddle.

@btecu
Copy link
Contributor

btecu commented Apr 26, 2018

This issue can be closed since into was removed from Ember 3.0.

https://www.emberjs.com/deprecations/v2.x/#toc_rendering-into-a-render-helper-that-resolves-to-an-outlet

@ef4 ef4 closed this as completed Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants