Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember.beforeObserver is missing on 1.13.4 #11742

Closed
juggy opened this issue Jul 14, 2015 · 5 comments
Closed

Ember.beforeObserver is missing on 1.13.4 #11742

juggy opened this issue Jul 14, 2015 · 5 comments

Comments

@juggy
Copy link
Contributor

juggy commented Jul 14, 2015

Please see http://jsbin.com/hifopu/4/edit?html,js,output

The console output is: Uncaught TypeError: Ember.beforeObserver is not a function
@stefanpenner
Copy link
Member

Hmm strange. It should be deprecated, but not removed

@juggy
Copy link
Contributor Author

juggy commented Jul 14, 2015

Must be related to 399a84d

@stefanpenner
Copy link
Member

Ya likely. I'm not going to be able to look at this today. It should be relatively easy to piece together the differences. Mind submitting a fix?

@juggy juggy mentioned this issue Jul 14, 2015
Merged
@juggy
Copy link
Contributor Author

juggy commented Jul 14, 2015

Voila.

juggy added a commit to juggy/ember.js that referenced this issue Jul 14, 2015
@juggy
Properly load deprecateFunc before calling it
bf59efb 
Solves emberjs#11742

Move deprecation to the bottom
rwjblue pushed a commit that referenced this issue Jul 15, 2015
@juggy @rwjblue
Properly load deprecateFunc before calling it
4c98c33 
Solves #11742

Move deprecation to the bottom

(cherry picked from commit bf59efb)
rwjblue pushed a commit that referenced this issue Jul 15, 2015
@juggy @rwjblue
Properly load deprecateFunc before calling it
c4149d9 
Solves #11742

Move deprecation to the bottom

(cherry picked from commit bf59efb)
@juggy
Copy link
Contributor Author

juggy commented Jul 15, 2015

Fix was merged to release. Thx.

@juggy juggy closed this as completed Jul 15, 2015
Eric-Guo added a commit to Eric-Guo/ember-examples-with-cli that referenced this issue Aug 7, 2015
@Eric-Guo
Enhanced version from broerse
356e1c1 
https://github.com/broerse/ember-cli-blog

notice if running Ember.js 1.13.4, need build ember.js yourself due to issue below.

emberjs/ember.js#11742
Eric-Guo added a commit to Eric-Guo/ember-examples-with-cli that referenced this issue Aug 7, 2015
@Eric-Guo
Enhanced version from broerse
5c4258f 
https://github.com/broerse/ember-cli-blog

notice if running Ember.js 1.13.4, need build ember.js yourself due to issue below.

emberjs/ember.js#11742
Eric-Guo added a commit to Eric-Guo/ember-examples-with-cli that referenced this issue Aug 9, 2015
@Eric-Guo
Enhanced version from broerse
f9a1337 
https://github.com/broerse/ember-cli-blog

notice if running Ember.js 1.13.4, need build ember.js yourself due to issue below.

emberjs/ember.js#11742
Eric-Guo added a commit to Eric-Guo/ember-examples-with-cli that referenced this issue Aug 11, 2015
@Eric-Guo
Enhanced version from broerse
7e0e542 
https://github.com/broerse/ember-cli-blog

notice if running Ember.js 1.13.4, need build ember.js yourself due to issue below.

emberjs/ember.js#11742
Eric-Guo added a commit to Eric-Guo/ember-examples-with-cli that referenced this issue Aug 13, 2015
@Eric-Guo
Enhanced version from broerse
0c990c2 
https://github.com/broerse/ember-cli-blog

notice if running Ember.js 1.13.4, need build ember.js yourself due to issue below.

emberjs/ember.js#11742
Eric-Guo added a commit to Eric-Guo/ember-examples-with-cli that referenced this issue Aug 14, 2015
@Eric-Guo
Enhanced version from broerse
cb93f5d 
https://github.com/broerse/ember-cli-blog

notice if running Ember.js 1.13.4, need build ember.js yourself due to issue below.

emberjs/ember.js#11742
Eric-Guo added a commit to Eric-Guo/ember-examples-with-cli that referenced this issue Aug 21, 2015
@Eric-Guo
Enhanced version from broerse
271474a 
https://github.com/broerse/ember-cli-blog

notice if running Ember.js 1.13.4, need build ember.js yourself due to issue below.

emberjs/ember.js#11742
Eric-Guo added a commit to Eric-Guo/ember-examples-with-cli that referenced this issue Aug 23, 2015
@Eric-Guo
Enhanced version from broerse
9fec9d6 
https://github.com/broerse/ember-cli-blog

notice if running Ember.js 1.13.4, need build ember.js yourself due to issue below.

emberjs/ember.js#11742
Eric-Guo added a commit to Eric-Guo/ember-examples-with-cli that referenced this issue Sep 12, 2015
@Eric-Guo
Enhanced version from broerse
b2ca893 
https://github.com/broerse/ember-cli-blog

notice if running Ember.js 1.13.4, need build ember.js yourself due to issue below.

emberjs/ember.js#11742
Eric-Guo added a commit to Eric-Guo/ember-examples-with-cli that referenced this issue Sep 12, 2015
@Eric-Guo
Enhanced version from broerse
7d4c3c8 
https://github.com/broerse/ember-cli-blog

notice if running Ember.js 1.13.4, need build ember.js yourself due to issue below.

emberjs/ember.js#11742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juggy @stefanpenner