-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logic to determine local template
lookup is incorrect.
#12134
Labels
Comments
EricSchank
added a commit
to EricSchank/ember.js
that referenced
this issue
Aug 21, 2015
@rwjblue I have a PR for this one. |
stable-1-13 is the correct branch to target. |
Here's the PR: #12164 |
rwjblue
added a commit
that referenced
this issue
Aug 22, 2015
[BUGFIX release-1-13] handle local template but no layout for component #12134
Fixed by #12164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a
layout
property is not present on a component, a component is invoked without a block, anddefaultTemplate
/template
/templateName
are present we completely ignore the layout.Demos:
1.13: http://jsbin.com/vowoti/edit?html,js,output
1.12: http://jsbin.com/pesehi/edit?html,js,output
https://github.com/emberjs/ember.js/blob/v1.13.8/packages/ember-htmlbars/lib/node-managers/component-node-manager.js#L168 should also be taking the
layout
looked up from the container (vialookupComponent
here) into consideration.Thanks to @elwayman02 for reporting.
The text was updated successfully, but these errors were encountered: