Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic to determine local template lookup is incorrect. #12134

Closed
rwjblue opened this issue Aug 17, 2015 · 4 comments
Closed

Logic to determine local template lookup is incorrect. #12134

rwjblue opened this issue Aug 17, 2015 · 4 comments

Comments

@rwjblue
Copy link
Member

rwjblue commented Aug 17, 2015

When a layout property is not present on a component, a component is invoked without a block, and defaultTemplate / template / templateName are present we completely ignore the layout.

Demos:

1.13: http://jsbin.com/vowoti/edit?html,js,output
1.12: http://jsbin.com/pesehi/edit?html,js,output


https://github.com/emberjs/ember.js/blob/v1.13.8/packages/ember-htmlbars/lib/node-managers/component-node-manager.js#L168 should also be taking the layout looked up from the container (via lookupComponent here) into consideration.

Thanks to @elwayman02 for reporting.

@EricSchank
Copy link
Contributor

@rwjblue I have a PR for this one.
I submitted it against emberjs:stable-1-13 since this code no longer exists in master or 2.x -- but not sure if that's the right branch.
If not, can you point me to the correct branch I should have as the merge target?
Thanks!

@rwjblue
Copy link
Member Author

rwjblue commented Aug 21, 2015

stable-1-13 is the correct branch to target.

@EricSchank
Copy link
Contributor

Here's the PR: #12164

rwjblue added a commit that referenced this issue Aug 22, 2015
[BUGFIX release-1-13] handle local template but no layout for component #12134
@rwjblue
Copy link
Member Author

rwjblue commented Aug 22, 2015

Fixed by #12164

@rwjblue rwjblue closed this as completed Aug 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants