ember-container-inject-owner - Checklist

[rwjblue]

• Implement FakeContainer concept discussed in [FEATURE ember-container-inject-owner]: Inject owner instead of container during lookup. #11874. This will help ensure full access to the container is possible, with a complete valid set of deprecations for each method or property accessed. The primary scenario that this affects that does not already have a deprecation is when the factory being instantiated does not have .extend.
• Ensure ember-test-helpers detects getOwner / setOwner and functions properly with this feature on or off.
• Document getOwner and setOwner functions in API docs. Document getOwner and setOwner #12562
• Audit and update guides details. I'm fairly sure we do not have any discussion of this.container in the guides (because it has been considered private API for ever), but we might want to add some prose to the dependency injection? Nudge toward 'owner' instead of 'container' guides#938, needs another PR to explain getOwner usage.
• Update ember-data to ensure deprecations are not triggered. Use public API for container/registry when possible. data#3912
• Add deprecation guide entry for the this.container deprecation (added in Add details for ember-contianer-inject-owner feature deprecations. website#2409) (and cross link the deprecation URL (done in [FEATURE ember-container-inject-getowner] Add deprecation URL. #12604)
• Update liquid-fire to prevent deprecations. Fix getOwner container deprecations for Canary. ember-animation/liquid-fire#388
• Update ember-i18n Use public API for container / registry functions. jamesarosen/ember-i18n#336

[dgeb]

Looks complete to me. Thanks for putting together this list, @rwjblue.

[mixonic]

@dgeb I will attempt docs for this stuff tonight and guides review. I hope that can free you up for some of the more tricky bits.

[dgeb]

@mixonic thanks - you're the best! Ping me if you have questions about the new stuff.

[rwjblue]

Feature is enabled by default. I am working on ember-test-helpers updates to make sure this is handled properly.

[dgeb]

Sounds good. I'll tackle the FakeContainer.

[mixonic]

FWIW guides have been given a cursory review, though I have not undertaken any long prose about "dynamic lookup" which I think may be the only app-based use case for getOwner (other cases being around testing, and usually testing internals).

[rwjblue]

Thanks @mixonic

[rwjblue]

I just published a polyfill that addons can use (https://github.com/rwjblue/ember-getowner-polyfill) pretty easily.

[rwjblue]

@tim-evans and I are working on updating ember-test-helpers to provide owner properly.

[rwjblue]

ember-qunit and ember-mocha versions have been released that take advantage of the new feature (checking the ember-test-helpers item off on the checklist).

[rwjblue]

I took some time to update ember-data in emberjs/data#3912. I'm hoping that those changes can make it into Ember Data 2.2.0 (but Ember Data 2.3.0 would be perfectly fine).

[rwjblue]

ember-data PR is merged (checked off above), and liquid-fire PR is submitted (ember-animation/liquid-fire#388).

[rwjblue]

@dgeb - Have you begun work on the FakeContainer bullet point?

[dgeb]

@rwjblue - sorry for the delay - I will try to wrap that up tomorrow

[rwjblue]

Added URL to the deprecation in #12604, and the deprecation guide in emberjs/website#2409.

[rwjblue]

@mixonic did the initial guide audit (mentioned in #12555 (comment)) and I just created emberjs/guides#982 to track updating the DI page with a few mentions of Ember.getOwner, so I am checking that item off for now.

[rwjblue]

Updated ember-i18n in jamesarosen/ember-i18n#336.

[dgeb]

Implemented fake container injection in #12609

[rwjblue]

Thanks @dgeb, that fix is merged completing the last item on this checklist. Closing (please let me know if I have forgotten something).