Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helpers made with Ember.Helper.extend(...) don't throw in block form #12804

Closed
mmun opened this issue Jan 11, 2016 · 0 comments
Closed

Helpers made with Ember.Helper.extend(...) don't throw in block form #12804

mmun opened this issue Jan 11, 2016 · 0 comments

Comments

@mmun
Copy link
Member

mmun commented Jan 11, 2016

See twiddle for a demo: https://ember-twiddle.com/733ca4c0d4212f1cb45d?openFiles=helpers.dupe.js%2Capplication.template.hbs

They should throw to align with helpers made with Ember.Helper.helper(function() { ... }).
Serabe added a commit to Serabe/ember.js that referenced this issue Jan 13, 2016
@Serabe
[BUGFIX beta] Fix block behaviour for Helper.extend helpers
d770aa8 
Change the condition in invoke helper assertions to throw on helpers extending
`Ember.Helper`.

Fixes emberjs#12804
@Serabe Serabe mentioned this issue Jan 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmun