$.trigger does not trigger component actions.

[ghost]

The test suites of ember-one-way-controls and ember-form-for will not pass on canary and 2.8.0-beta.

An example of what is failing: https://github.com/martndemus/ember-form-for/blob/master/tests/integration/components/form-field-test.js#L156-L164

Specifically this does not seem to trigger actions on components anymore:

this.$('input').trigger('change');

Using git bisect I found that components/ember@9cff2f8 is the commit that introduces the bug, which I think corresponds to this commit: 2a233df

[pixelhandler]

@martndemus I'm curious, in this.$('input').trigger('change'); an action named change should be triggered? Or, an event handler named change (not an action)? I thought trigger is a jQuery method that fires events.

[rwjblue]

The issue would likely be (based on the bisect result) that the event dispatched cannot find the component that is created, so it doesn't delegate the event to it. I'll try to dig in more this morning.

[mike-north]

worth mentioning that it seems this only occurs during testing. When apps are run normally, everything seems to work as one would expect

[ghost]

It is very probable that this is a bug with test tooling working on old View API, that the found commit has broken.

[pixelhandler]

@martndemus Just curious is this post https://dockyard.com/blog/2016/07/26/how-to-bisect-ember about this issue?

[ghost]

Yes, the blogpost describes how I found the commit that causes the bug.

[acorncom]

@martndemus Would it be possible to get a Twiddle showing a reproduction?

[alexlafroscia]

I tried making a Twiddle here but for some reason the whole test thing shows up blank ¯_(ツ)_/¯

[alexlafroscia]

Seems to be a bug in Twiddle

[ghost]

@acorncom Reproduction is: clone https://github.com/martndemus/ember-form-for/commit/206cc307740bfa07de6eee48cebbca14839651eb and run ember test

[alexlafroscia]

You can see the same problem on the master branch of Ember AJAX right now too.

[rwjblue]

This is definitely an issue with an interaction between the change that @martndemus pointed out and the way ember-test-helpers sets up the event dispatcher. Ultimately, this causes the event dispatcher gets the event but can't identify which view it should be triggering.

I'll try to get a fix together in time for the next beta.

[rwjblue]

I did a bit more digging and believe that we have this fixed with emberjs/ember-test-helpers#167 (released in ember-test-helpers@0.5.28) and ffc29cd (which is cherry-picked into beta branch).

The basic issue is that since the Ember.Aplication and Ember.ApplicationInstance split there was no good way to execute the registry setup steps that existed in Em.ApplicationInstance. ember-test-helpers uses Ember.Application.buildRegistry to create the registry/container/owner setup that is used in unit and integration tests, but since there was no way to perform the Em.ApplicationInstance registry setup steps we were missing some key injections.

Submitted https://github.com/martndemus/ember-form-for/pull/79 to update and kick off a test run in ember-form-for showing that things are working properly now.

[ghost]

Can confirm this is fixed now. Closing the issue!