Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.click() not triggering in integration tests in Ember 2.8.0 #13932

Closed
alexlafroscia opened this issue Jul 28, 2016 · 3 comments
Closed

.click() not triggering in integration tests in Ember 2.8.0 #13932

alexlafroscia opened this issue Jul 28, 2016 · 3 comments

Comments

@alexlafroscia
Copy link

alexlafroscia commented Jul 28, 2016

I've noticed a test failing in Ember 2.8.0 (as well as the current canary build) in the ember-ajax repo. I've traced it back to this line here where an element should be clicked. That should trigger the click() event on the component in that test, but it doesn't.

Is that an intentional change or a bug? If it's intentional, how would one define a general click handler instead?

@rwjblue
Copy link
Member

rwjblue commented Jul 28, 2016

I believe that this is a duplicate of #13888, but haven't had a chance to dig in and confirm.

@Serabe
Copy link
Member

Serabe commented Jul 28, 2016

Closing as a duplicate given internally click() calls trigger.

jQuery.each( ( "blur focus focusin focusout load resize scroll unload click dblclick " +
    "mousedown mouseup mousemove mouseover mouseout mouseenter mouseleave " +
    "change select submit keydown keypress keyup error contextmenu" ).split( " " ),
    function( i, name ) {

    // Handle event binding
    jQuery.fn[ name ] = function( data, fn ) {
        return arguments.length > 0 ?
            this.on( name, null, data, fn ) :
            this.trigger( name );
    };
} );

@Serabe Serabe closed this as completed Jul 28, 2016
@alexlafroscia
Copy link
Author

Thanks for triaging; I'll keep an eye on that issue for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants