Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Glimmer 2] Component Integration Tests #13963

Closed
dfreeman opened this issue Jul 30, 2016 · 4 comments
Closed

[Glimmer 2] Component Integration Tests #13963

dfreeman opened this issue Jul 30, 2016 · 4 comments
Assignees

Comments

@dfreeman
Copy link
Contributor

dfreeman commented Jul 30, 2016

In a freshly-minted app using the Ember alpha released today, integration tests fail.

Here's a repo reproducing the issue, which just followed these steps:

ember new test-app
cd test-app
bower install -S ember#alpha
ember g component-test fails
ember test
@rwjblue
Copy link
Member

rwjblue commented Jul 30, 2016

I fixed the direct issue reported here in #13970 and emberjs/ember-test-helpers#167, but the reproduction steps are still an issue due to the way top level outlets are being used by ember-test-helpers.

@rwjblue rwjblue changed the title [Glimmer 2] Error: Could not find module ember-htmlbars/setup-registry [Glimmer 2] Component Integration Tests Jul 30, 2016
@rwjblue
Copy link
Member

rwjblue commented Jul 31, 2016

@rwjblue
Copy link
Member

rwjblue commented Aug 1, 2016

With the changes from ember-test-helpers@0.5.29 a basic this.render should be working (submitted dfreeman/glimmer-integration-failure#1 to the test repo).

A generic ember g component x-foo will still fail due to the lack of support for this.clearRender() in ember-test-helpers at the moment (still working on that).

@rwjblue
Copy link
Member

rwjblue commented Aug 1, 2016

As of ember-test-helpers@0.5.30 ember g component it-works passes without change. I submitted dfreeman/glimmer-integration-failure#2 to demonstrate.

I'm going to consider this finished (though please chime in if there are issues and I'll reopen).

@rwjblue rwjblue closed this as completed Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants