Registry setup fixes #13970
Merged
Registry setup fixes #13970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 29, 2016 20:21
ember-test-helpers calls `Ember.Application.buildRegistry` to create a registry for its testing harness. Prior to these changes, `options[GLIMMER]` would be `undefined` and therefore throw an error when building a registry in the alpha series.
Glimmer requires that a number of factories and injections added by `ApplicationInstance#setupRegistry` are present, but the testing harness only has access to calling `Ember.Application.buildRegistry` which leaves the registry in a partially populated state. This exposes `Ember.ApplicationInstance.setupRegistry` so that `ember-test-helpers` can ensure that its registry is properly populated.
rwjblue
force-pushed
the
registry-setup-fixes
branch
from
fc415ec to
ffc29cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember.Application.buildRegistryuses Glimmer registry in alpha. ember-test-helpers callsEmber.Application.buildRegistryto create a registry for its testing harness. Prior to these changes,options[GLIMMER]would beundefinedand therefore throw an error when building a registry in the alpha series.Ember.ApplicationInstance.setupRegistryfor tooling. Glimmer requires that a number of factories and injections added byApplicationInstance#setupRegistryare present, but the testing harness only has access to callingEmber.Application.buildRegistrywhich leaves the registry in a partially populated state. This exposesEmber.ApplicationInstance.setupRegistryso thatember-test-helperscan ensure that its registry is properly populated.Addresses part of the issues identified in #13963.