Component rendering mutates module meta #14192
Labels
Comments
This was referenced Sep 2, 2016
|
@krisselden who should this issue be assigned to? |
krisselden
added a commit
that referenced
this issue
Sep 6, 2016
krisselden
added a commit
that referenced
this issue
Sep 6, 2016
Ensure rerender in ComponentNodeManager passes meta the same way as it does in render. Remove invalid fix to above issue that caused moduleName to be incorrectly mutated.
rwjblue
pushed a commit
that referenced
this issue
Sep 6, 2016
Ensure rerender in ComponentNodeManager passes meta the same way as it does in render. Remove invalid fix to above issue that caused moduleName to be incorrectly mutated. (cherry picked from commit 4f9383d)
|
@krisselden @rwjblue this can be closed now, right? |
|
Ya, was fixed in 2.7.3 and 2.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're attempting to upgrade our application to 2.7.2 and ran into an odd issue. Brief backstory, we rely on the
meta.moduleNameproperty from the compiled HTMLBars template to do some of our lookups for localization.While attempting the upgrade, there are some tests that we have that are now failing after being run in a certain order. After a lot of debugging, the root issue is that the
meta.moduleNameproperty is being mutated which causes the value to be incorrect when we do our lookup for the translation.The offending line of code seems to be this: https://github.com/emberjs/ember.js/blob/v2.7.2/packages/ember-htmlbars/lib/hooks/component.js#L62
I haven't narrowed down the exact circumstances under which this occurs, but in some cases it appears
env.metais the same reference as themetaproperty from a templates AMD module. Thus, iftemplateMeta.moduleNameis used, the module is then mutated permanently.cc @asakusuma @zackthehuman
The text was updated successfully, but these errors were encountered: