[Glimmer2] Runtime exception when yielding values within partial #14642
Labels
Comments
This was referenced Nov 27, 2016
|
Just added a (failing) test: #14643 |
|
Oops. Thank you for reporting! I am looking into it |
chancancode
added a commit
to glimmerjs/glimmer-vm
that referenced
this issue
Nov 27, 2016
- Move the "prelude" compilation into the DSL - Ensure component layouts using partials always get the caller scope Fixes emberjs/ember.js#14642
|
@simonihmig should be fixed now! |
chancancode
pushed a commit
that referenced
this issue
Nov 27, 2016
(cherry picked from commit 8ec69ba)
|
Confirmed, this finally fixes the remaining failing tests for Glimmer2 in ember-bootstrap, all green now! Thanks a lot! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is related to #14263, which was fixed by @chancancode recently. But a new error could be observed, that seems to be very much related.
After the changes from #14633
hasBlockworked again, but I started to get an exception ofTypeError: Cannot read property 'child' of nullin my build: https://travis-ci.org/kaliber5/ember-bootstrap/builds/179128906#L559. This is coming fromVM.pushChildScope, so within Glimmer itself it seems.Took me quite some time to isolate this, but it seems it happens when yielding values from the partial. Here is a Twiddle that reproduces this: https://ember-twiddle.com/5a29e54ab543a2668f1d725375d2e0ea
The text was updated successfully, but these errors were encountered: