Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glimmer 2 does not read properties on functions #14739

Closed
kturney opened this issue Dec 19, 2016 · 5 comments
Closed

Glimmer 2 does not read properties on functions #14739

kturney opened this issue Dec 19, 2016 · 5 comments

Comments

@kturney
Copy link
Contributor

kturney commented Dec 19, 2016

We encountered this while upgrading a project that uses https://github.com/LocusEnergy/ember-d3-helpers to Ember 2.10 and trying to bind to properties on D3 scales.

Twiddle: https://ember-twiddle.com/8bd17be80e30f6149bcdf644f3d1f68d?openFiles=templates.application.hbs%2C

If you change the Ember version in the twiddle to 2.9, the property renders as expected.

pr with failing test: #14729

@chancancode
Copy link
Member

I think I know how to fix this, but I am on vacation. If anyone wants to look into it there are a few places where we do if (typeof foo === "object") that should include functions as well. I believe it probably needs both a glimmer fix and an ember fix to cover all the cases.

@chancancode
Copy link
Member

PrimitiveReference and such

@locks locks self-assigned this Dec 22, 2016
@Serabe
Copy link
Member

Serabe commented Jan 13, 2017

@locks, any update on this?

@mixonic
Copy link
Member

mixonic commented Mar 26, 2017

afaict this is still an issue.

@locks
Copy link
Contributor

locks commented Aug 25, 2017

This should be fixed by #15535.

@locks locks closed this as completed Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants