Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Fix rendering a property of a function #15535

Merged
merged 2 commits into from
Jul 22, 2017
Merged

Conversation

krisselden
Copy link
Contributor

No description provided.

@krisselden
Copy link
Contributor Author

Rebased and focused version of #15482 on just the regression. Before 2.10 you could render a property of a function, but you couldn't notify it updated. This should make its way into the LTS since this regressed in 2.10 /cc @rwjblue @locks

It is simple to support updates too, I just don't think it should be back ported since it wasn't possible before.

@krisselden krisselden requested a review from rwjblue July 20, 2017 23:05

this.assertStableRerender();

// this.runTask(() => set(func, 'aProp', 'still a property on a function'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why comments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because I missed that? I didn't comment it out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test was trying to do INUR (which is likely what prompted the fixing of the updating side also), so my guess is that the update/reset parts here are just commented out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants