Allow running acceptance tests without jQuery

[cibernox]

As part of the work of the work performed in https://github.com/cibernox/ember-native-dom-helpers to provide consistent jquery-free test helpers that work both in integration and acceptance I've found that acceptance tests don't work without jQuery.

The reason for that is (at least) this file: https://github.com/emberjs/ember.js/blob/master/packages/ember-testing/lib/setup_for_testing.js#L38-L44

The task is to feature-detect jquery and skip those lines if not present.

For those interested, you can see how to remove jquery from an ember-app in this commit: cibernox/ember-native-dom-helpers@5ebeeb6

[rwjblue]

I submitted #15065 for the specific thing mentioned, but I suspect there are more things that we need to do after that lands.

[pixelhandler]

@cibernox @rwjblue should this be in a RFC issue (not PR) instead of here? @Serabe are will still encouraging feature types of issues to go through the RFCs repo?

[rwjblue]

@pixelhandler - This isn't really adding a new feature at all. Simply removing an error condition in one usage scenario. We are definitely not saying that folks should drop jQuery (only they want to), and we are not modifying the default blueprint.

[mixonic]

Are there more items to cover here @cibernox, or can this issue be closed?

[rwjblue]

@mixonic - The first known issue was addressed but we need to test again against canary builds. I haven't had a chance yet TBH.

[cibernox]

I just tried and no, there is still more work to do. I will be able to help with this after emberconf.

[samjjc]

I would like to work on this. It might take a little time, though. I am new here. any advice to help me get started is welcome

[Serabe]

@cibernox ping!

[cibernox]

Can u ping me next week? This one I'm on the verge of collapse

…

On Jul 13, 2017 1:22 PM, "Sergio Arbeo" ***@***.***> wrote: @cibernox <https://github.com/cibernox> ping! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15063 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQMe9xAxZPxQtiZEA4kz96kJBgzk04Lks5sNgwTgaJpZM4Mn8tk> .

[Serabe]

I know! It was more a simulación en diferido de ping.

[pixelhandler]

@cibernox does this issue need to stay open?

[cibernox]

Actually, no. Acceptance tests are fine, provided people don't use the built-in global helper (find, fillIn) but the ones in https://github.com/cibernox/ember-native-dom-helpers

I'll close it.