Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quest] Mocha Blueprints for RFCs 232/268 #16863

Closed
9 of 12 tasks
Dhaulagiri opened this issue Aug 3, 2018 · 10 comments
Closed
9 of 12 tasks

[Quest] Mocha Blueprints for RFCs 232/268 #16863

Dhaulagiri opened this issue Aug 3, 2018 · 10 comments

Comments

@Dhaulagiri
Copy link
Contributor

Dhaulagiri commented Aug 3, 2018

Background

#15933 updated the blueprints for Qunit to reflect the changes made in RFC 232 and RFC 268. As of ember-mocha 0.14.0 we can implement these same blueprints for Mocha tests as well.

The desired behavior when generating testing blueprints is to generate "Simplified Mocha" style tests if supported by the host app. We have several tasks below to extend the blueprints to support the "Simplified Mocha" style blueprints alongside the legacy, and ember-mocha blueprints.

Tasks

@rwjblue
Copy link
Member

rwjblue commented Aug 4, 2018

An ember-mocha with the newer APIs hadn’t landed at that point (the repo needed more work before it was ready). I think at this point the best path is to make a quest style issue with a checklist and guidance. Generally speaking these efforts move forward fairly quickly.

I personally would love to see updated blueprints land in time for 3.4 (current beta).

@Dhaulagiri Dhaulagiri changed the title No RFC 232/268 blueprints for Mocha test suites? [Quest] Mocha Blueprints for RFCs 232/268 Aug 4, 2018
@Dhaulagiri
Copy link
Contributor Author

@rwjblue I copied over the quest items from the qunit issue here to turn this into a quest for updating the mocha blueprints. Let me know if this plan seems sound (I'm a little out of the loop).

@shadi4778
Copy link

issue

@Dhaulagiri
Copy link
Contributor Author

I'll probably need help with the initializer tests as they seem to differ from qunit in ways that I can't quite understand the "right" way to write them

@rwjblue
Copy link
Member

rwjblue commented Sep 4, 2018

Sorry for the delays here, I was on vacation and am only finally getting caught back up. I merged the ones that seemed ready, and commented on some of the others (needing a rebase / restarting CI for flakyness / etc).

@simonihmig
Copy link
Contributor

I'll probably need help with the initializer tests as they seem to differ from qunit in ways that I can't quite understand the "right" way to write them

I am interested in wrapping this up. @Dhaulagiri can you elaborate on this? How/why would the Mocha tests have to differ?

@Dhaulagiri
Copy link
Contributor Author

@simonihmig i wish I had been more specific here, but if I recall correctly if I tried to mimic the same application test setup as the qunit tests I was running into unexpected errors in the mocha tests.

@simonihmig
Copy link
Contributor

Here are two PRs for the missing (instance-) initializer blueprints: #17411, #17412

simonihmig added a commit to simonihmig/ember.js that referenced this issue Mar 6, 2019
simonihmig added a commit to simonihmig/ember.js that referenced this issue Mar 6, 2019
simonihmig added a commit to simonihmig/ember.js that referenced this issue Mar 7, 2019
simonihmig added a commit to simonihmig/ember.js that referenced this issue Mar 7, 2019
@simonihmig
Copy link
Contributor

With the above two PRs being merged, the remaining points can be checked off and this issue closed! 🎉

@Dhaulagiri
Copy link
Contributor Author

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants