Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Show using {{on}} for input components #19201

Closed
jenweber opened this issue Oct 16, 2020 · 5 comments
Closed

[Documentation] Show using {{on}} for input components #19201

jenweber opened this issue Oct 16, 2020 · 5 comments

Comments

@jenweber
Copy link
Contributor

jenweber commented Oct 16, 2020

In the API guides for input, we show passing actions like this:

<Input @value={{this.searchWord}} @enter={{this.query}} />

However, for Octane-style apps, the preferred way of adding actions to inputs is to use {{on}}, as shown in this part of the Guides:

<label for="input-name">Name:</label>
<Input
  @id="input-name"
  @value={{this.name}}
  @input={{this.validateName}}
/>

To-do:

  • Add a brief example using {{on}} to the Input API docs page. It's here. Do not remove any existing explanation of other events/styles. If there is an example from the Guides that you think works well here, use that instead of writing something new.
@romance939913
Copy link
Contributor

Hi @jenweber - Can I take a stab at this??

@jenweber
Copy link
Contributor Author

@romance939913 that would be awesome! Please get in touch if you have questions.

@GuptaTanisha
Copy link

@jenweber Can I work on this issue?

@bertdeblock
Copy link
Member

Since #19314 is merged, I think we can close this?

@jenweber
Copy link
Contributor Author

jenweber commented Mar 1, 2021

Yes, that's correct. Sorry we forgot to close this issue when the PR was merged. Thanks everyone for your willingness to help :)

@jenweber jenweber closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants