Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate using {{on}} with <Input ... />. #19314

Merged
merged 7 commits into from
Jan 15, 2021

Conversation

romance939913
Copy link
Contributor

Fixes issue #19201 <== [Documentation] Show using {{on}} for input components

@romance939913
Copy link
Contributor Author

Hi @jenweber - Do you know what could be causing this linting error?? The only commands I've run are "yarn install", "yarn build", "yarn start" and "yarn test"

Also how do my additions to the input.ts file look?

@jenweber
Copy link
Contributor

Hi! Thanks for your work on this. Seems like you figured out where to do the work and all that. The linting errors are the following:

ERROR: /home/runner/work/ember.js/ember.js/packages/@ember/-internals/glimmer/lib/components/input.ts:60:85 - trailing whitespace
ERROR: /home/runner/work/ember.js/ember.js/packages/@ember/-internals/glimmer/lib/components/input.ts:70:81 - trailing whitespace

These mean that you should delete the "space" at the ends of lines 60 and 70. You can see these errors by clicking "details" next to the failure notice.

@romance939913
Copy link
Contributor Author

Thanks for clearing that up @jenweber !! Let me know if this branch is good to be merged or If I need to do anything else.

Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey :) Left some suggestions inline.

romance939913 and others added 3 commits December 18, 2020 08:23
add handlebars commit suggestion

Co-authored-by: Ricardo Mendes <rokusu@gmail.com>
add backticks around {{on}} modifier to make it render like code

Co-authored-by: Ricardo Mendes <rokusu@gmail.com>
add backticks around other input actions so they render like code

Co-authored-by: Ricardo Mendes <rokusu@gmail.com>
@romance939913 romance939913 requested a review from locks December 18, 2020 14:14
@locks locks requested a review from jenweber December 20, 2020 01:17
@romance939913
Copy link
Contributor Author

romance939913 commented Dec 20, 2020

Hi @jenweber - How does my branch look now? Is it ready to be merged?

@romance939913
Copy link
Contributor Author

Hi @jenweber - Just making sure you saw my last message. Is this PR ready to be merged?

@rwjblue rwjblue merged commit a4fb9fc into emberjs:master Jan 15, 2021
@rwjblue rwjblue changed the title Docs show on input component Demonstrate using {{on}} with <Input ... />. Jan 15, 2021
@rwjblue
Copy link
Member

rwjblue commented Jan 15, 2021

Thank you @romance939913!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants