-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demonstrate using {{on}}
with <Input ... />
.
#19314
Demonstrate using {{on}}
with <Input ... />
.
#19314
Conversation
Hi @jenweber - Do you know what could be causing this linting error?? The only commands I've run are "yarn install", "yarn build", "yarn start" and "yarn test" Also how do my additions to the input.ts file look? |
Hi! Thanks for your work on this. Seems like you figured out where to do the work and all that. The linting errors are the following:
These mean that you should delete the "space" at the ends of lines 60 and 70. You can see these errors by clicking "details" next to the failure notice. |
Thanks for clearing that up @jenweber !! Let me know if this branch is good to be merged or If I need to do anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey :) Left some suggestions inline.
add handlebars commit suggestion Co-authored-by: Ricardo Mendes <rokusu@gmail.com>
add backticks around {{on}} modifier to make it render like code Co-authored-by: Ricardo Mendes <rokusu@gmail.com>
add backticks around other input actions so they render like code Co-authored-by: Ricardo Mendes <rokusu@gmail.com>
Hi @jenweber - How does my branch look now? Is it ready to be merged? |
Hi @jenweber - Just making sure you saw my last message. Is this PR ready to be merged? |
{{on}}
with <Input ... />
.
Thank you @romance939913! |
Fixes issue #19201 <== [Documentation] Show using
{{on}}
for input components