Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate using {{on}} with <Input ... />. #19314

Merged
merged 7 commits into from
Jan 15, 2021
Merged

Demonstrate using {{on}} with <Input ... />. #19314

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5725182
add input action example using the {{on}} modifier with information o…
romance939913 Dec 18, 2020
ecce989
yarn install/yarn build/yarn test, fixing issue 19201
romance939913 Dec 18, 2020
186703a
wrap input example in triple backticks to tender code block
romance939913 Dec 18, 2020
e9bf71b
delete trailing whitespace in input.ts lines 60 and 72
romance939913 Dec 18, 2020
6458381
Update packages/@ember/-internals/glimmer/lib/components/input.ts
romance939913 Dec 18, 2020
5169e5c
Update packages/@ember/-internals/glimmer/lib/components/input.ts
romance939913 Dec 18, 2020
f38ddd9
Update packages/@ember/-internals/glimmer/lib/components/input.ts
romance939913 Dec 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packages/@ember/-internals/glimmer/lib/components/input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,21 @@ import InternalComponent from './internal';
<Input @value={{this.searchWord}} @enter={{this.query}} />
```

Starting with Ember Octane, we recommend using the {{on}} modifier to call actions
romance939913 marked this conversation as resolved.
Show resolved Hide resolved
on specific events, such as the input event.

```
romance939913 marked this conversation as resolved.
Show resolved Hide resolved
<label for="input-name">Name:</label>
<Input
@id="input-name"
@value={{this.name}}
{{on "input" this.validateName}}
/>
romance939913 marked this conversation as resolved.
Show resolved Hide resolved
```

The event name (e.g. "focusout", "input", "keydown") always follows the casing
romance939913 marked this conversation as resolved.
Show resolved Hide resolved
that the HTML standard uses.

### `<input>` HTML Attributes to Avoid

In most cases, if you want to pass an attribute to the underlying HTML `<input>` element, you
Expand Down