Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate slash as namespace #5260

Closed
2 tasks
wagenet opened this issue Jul 28, 2014 · 8 comments
Closed
2 tasks

Deprecate slash as namespace #5260

wagenet opened this issue Jul 28, 2014 · 8 comments
Assignees
Milestone

Comments

@wagenet
Copy link
Member

wagenet commented Jul 28, 2014

Currently a slash in lookups is used for namespaces. We'll be deprecating this.

  • next release: deprecate
  • subsequent release: remove code
@stefanpenner
Copy link
Member

👍

@wagenet wagenet changed the title Deprecate slash as namspace Deprecate slash as namespace Jul 28, 2014
@stefanpenner
Copy link
Member

i'll start the deprecation process tonight (@rwjblue are you free to pair tonight?)

@stefanpenner stefanpenner self-assigned this Jul 28, 2014
@wagenet
Copy link
Member Author

wagenet commented Nov 1, 2014

@stefanpenner status?

@wagenet wagenet added the Cleanup label Nov 1, 2014
@stefanpenner
Copy link
Member

still pending

@machty
Copy link
Contributor

machty commented Feb 23, 2015

Just to clarify so that I might not confuse myself about this in the future: namespace in this context refers to global namespaces; it does not refer to route "namespaces". In the case of routes, we want to support this.resource('foo/bar') and deprecate this.resource('foo.bar') (please someone correct me if I'm wrong).

@stefanpenner
Copy link
Member

In the case of routes, we want to support this.resource('foo/bar') and deprecate this.resource('foo.bar') (please someone correct me if I'm wrong).

you are correct

@stefanpenner stefanpenner added this to the 1.13.x milestone Jul 8, 2015
@stefanpenner
Copy link
Member

We MUST kill this for 2.0 this time. I will basically quit computers if we dont

@stefanpenner
Copy link
Member

// # legacy namespace
name = name.replace(/\//g, '.');
// \ legacy slash as namespace support
cc @martndemus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants