The render helper is not looking up controllers properly

[seanrucker]

In the blog post announcing RC2 it specifically states with regard to the render helper that:

If you want to use an alternative namespace, you can use a /-separated path.

{{render 'blog/posts'}}

This will render the blog/posts template with the controller Blog.PostsController

This is incorrect because the render helper is still using the old dot notation. Specifically this line is responsible for causing the lookup to fail:

https://github.com/emberjs/ember.js/blob/v1.0.0-rc.3/packages/ember-routing/lib/helpers/render.js#L43

Commenting out fixes the problem.

[twokul]

Seems to work with RC-4. Or am I missing something here?

http://jsbin.com/axixuf/2

[jonnii]

Your controller isn't in a namespace. I think this is actually still an issue. I think something like this should work, but I'm not exactly sure how you create a new namespace...

http://jsfiddle.net/8mNjc/1/

[seanrucker]

This is still an issue from what I can tell. You're jsbin shows that it correctly pulls the template, but it doesn't run with the proper controller. This shows what I'm talking about:

http://jsbin.com/upoxuc/1/

[jonnii]

If you change your controller name to App.BlogIndexController then it'll work. The question is, is this supposed to resolve the controller in the namespace, App.BlogIndexController or either?

[seanrucker]

According to the Ember blog it should lookup Blog.IndexController.

"This will render the blog/posts template with the controller Blog.PostsController."

http://emberjs.com/blog/2013/03/30/ember-1-0-rc2.html

[krisselden]

@wagenet I'm assigning you simply because you are the author of 0ebaef1 feel free to reassign

[wagenet]

I'm pretty sure my commit was added before namespaces. We decided to treat slashes the same as dot notation for ease of use. With namespaces, this is no longer the behavior we want. The only risk to removing this is if people were relying on the slash notation for the dot notation behavior. Maybe someone could put an error handler in so that if the namespace doesn't exist then it tells people that they might want to try dot notation?

[balinterdi]

@wagenet The error handler you mention would basically just inform the developer that slashes can't be used to delimit namespaces, and that she should use dots to achieve this, right?

[balinterdi]

It seems to me that neither {{ render 'blog.index' }} (see http://jsfiddle.net/LNWwH/5) nor {{ render 'blog/index' }} (see http://jsfiddle.net/balinterdi/LNWwH/4/) looks up the namespaced controller and thus neither of these versions work.

[zeevallin]

This is the only way I could get it to work.

template:

{{render "sidebar/user" model.user controller='app/Sidebar/User'}}

controller:

App.Sidebar ||= Ember.Namespace.create()
App.Sidebar.UserController = Ember.Controller.extend()

[seanrucker]

I put through a PR for this issue: #3063

@wagenet There is already an existing error message. If you try to use slash notation and the namespace doesn't exist it displays:

"Assertion failed: You are looking for a index view in the Blog namespace, but the namespace could not be found"

[wagenet]

Just a heads up, @stefanpenner decided not to merge @seanrucker's PR. We're doing some more in-depth overhauling of the container normalization which should cover this.

[stefanpenner]

we want to encapsulate the normalization rules to the resolver. So it will becomes easy to switch out as peoples module/resolution needs change. A side effect, is that we should be able to provide a defaultResolver with todays broken behaviour, for those that don't care. While allowing people to opt into a more modern resolver.

[stefanpenner]

An update, the resolver now encapsulates the normalization rules: b7fe725

This will allow us to continue to support the existing behaviour, but allow others to opt-in to a more consistent experience, like we do in EAK: https://github.com/stefanpenner/ember-app-kit/blob/master/vendor/loader.js#L41

As the slash clearly causes issues, we will likely see a different mechanism of declaring a namespace. The current thought is @

<type>:<name>@<namespace>
view:button@bootstrap

or more related to the above issue, maybe something like:

{{render 'posts@blog'}}

[stefanpenner]

it looks like we will add a flag, so people can toggle this behaviour. as '/' for namespace doesn't work anymore. Then we can transition people to a above described pattern

[wagenet]

@stefanpenner, does this even make sense anymore?

[stefanpenner]

So I'm not terribly motivated to hack a solution as in the new module world everything works wonderfully.

At some point we should sort this out, but I don't have the time to fix this. If someone has time, I will give them advice

[wagenet]

Closing for now, but PRs are welcome.

[stefanpenner]

please aggregate this into "deprecate slash as namespace"

[wagenet]

See #5260