-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify and modularize app/router initialization #10256
Merged
Merged
Commits on Jan 21, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 585a935 - Browse repository at this point
Copy the full SHA 585a935View commit details -
Default resolver matches CLI resolver
main
The CLI resolver always treats type keys with the name of `main` as top-level objects. For example, `router:main` resolves to `app/router.js` instead of `app/routers/main.js`. This change updates the default resolver to always look for `foo-bar:main` as `App.FooBar`. This is in anticipation of application init/boot cleanup that we are doing as part of the FastBoot effort.
Configuration menu - View commit details
-
Copy full SHA for 0320b5a - Browse repository at this point
Copy the full SHA 0320b5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 788580f - Browse repository at this point
Copy the full SHA 788580fView commit details -
Store an ApplicationInstance on the Application
Instead of storing a `__container__` on the Application, this commit stores an ApplicationInstance, which manages the per-instance lifecycle. The next step will be allowing multiple `ApplicationInstance`s to exist at once, enabling a single app to serve multiple FastBoot requests at a time. This is a conceptual improvement that brings application “reset” in line with the destruction infrastructure. As part of this commit, we eliminated an ad-hoc call to router.reset(), allowing that logic to happen as a natural consequence of destruction of the `ApplicationInstance`. In general, the goal of this commit is to move all responsibility for application state into an object that manages it.
Configuration menu - View commit details
-
Copy full SHA for 0941344 - Browse repository at this point
Copy the full SHA 0941344View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c2b8d4 - Browse repository at this point
Copy the full SHA 9c2b8d4View commit details
Commits on Jan 22, 2015
-
ApplicationInstance should create container
Based on feedback from @stefanpenner, we moved responsibility for creating the default container from the `Application` to the `ApplicationInstance`. Instead, the instance points back at the application’s registry, using it as the basis for a new container. This commit also adds initial documentation to the application instance.
2Configuration menu - View commit details
-
Copy full SHA for 434e9cc - Browse repository at this point
Copy the full SHA 434e9ccView commit details -
Introduce instance initializers
This commit introduces a new (feature flagged) API for adding instance initializers. Instance initializers differ from normal initializers in that they are passed the app instance rather than a registry, and therefore can access instances from the container in a safe way. This design not only allows us to avoid expensive app setup for each FastBoot request, it also minimizes the amount of work required between acceptance test runs (once the testing infrastructure is updated to take advantage of it). This commit also removes a previously introduced deprecation that was not behind a feature flag. That deprecation (when emitted with the feature flag enabled) now points to a comprehensive deprecation guide.
Configuration menu - View commit details
-
Copy full SHA for cf55da2 - Browse repository at this point
Copy the full SHA cf55da2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73d3ee0 - Browse repository at this point
Copy the full SHA 73d3ee0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 496dfe7 - Browse repository at this point
Copy the full SHA 496dfe7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a16adec - Browse repository at this point
Copy the full SHA a16adecView commit details -
Configuration menu - View commit details
-
Copy full SHA for e929b74 - Browse repository at this point
Copy the full SHA e929b74View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.