[BUGFIX beta] Make computed.or return more like ||

[soulcutter]

Given the recent deprecation of computed.any in favor of computed.or it
seems more-appropriate to return the last falsy value to enable
these computed properties to potentially be rendered directly in
templates without the need to be wrapped in {{#if}} blocks.

The behavior of computed.any was to return null, so this brings
computed.or more inline with replacing computed.any

The way javascript || works is that it returns the last value, so

undefined || null // => null
null || undefined // => undefined
null || false // => false

Edit: update to fix merge conflict, the way computed properties are declared/exported changed slightly

[wagenet]

/cc @stefanpenner

[stefanpenner]

hmm, I would like someone elses input on this @wycats r?

[soulcutter]

Alternately computed.or could return null instead of false like computed.any did, which would make it more-useful for properties that end up getting rendered in templates.

[soulcutter]

I'd like to resolve this one way or another - I think it's relatively important given the deprecation of any which suggests using or, which would be a poor substitute in situations where you are rendering the property and would prefer that it rendered nothing rather than false.

What are the objections or discussion points around this?

[stefanpenner]

@soulcutter can you rebase this, we can get it in for 2.0.

Please rename it to [BUGFIX beta]

[soulcutter]

Sure - when you say rename it, do you mean to prefix the commit message with that, or replace it completely with that? I assume "it" is the commit message

[stefanpenner]

do you mean to prefix the commit message with that,

^^

[soulcutter]

Done.

[stefanpenner]

yay!

[rwjblue]

@soulcutter - I'm sorry I missed your last comment. Looks like this needs another rebase.

[soulcutter]

Ok I rebased again. Fourth time is a charm? I hope this time is the last…

[rwjblue]

Thank you!