[BUGFIX beta] Fix broken unregisterWaiter semantics #10276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| App.testHelpers.wait().then(function() { | ||
| equal(obj.ready(), true, 'should not resolve until our waiter is ready'); | ||
| Test.unregisterWaiter(obj, obj.ready); | ||
| equal(Test.waiters.length, 0, 'should not leave a waiter registered'); | ||
| equal(Test.waiters.length, 1, 'should not leave the waiter registered'); | ||
| App.testHelpers.wait().then(function() { |
There was a problem hiding this comment.
This nesting seems odd. Can you return wait() here, and then chain the past assertion off the outside promise (instead of nesting another level)?
Ember.Test.unregisterWaiter is supposed to unregister only the waiter that matches the arguments you pass it. Due to a bug it actually unregisters all waiters with the same context.
ef4
force-pushed
the
fix-unregister-waiter
branch
from
a63af03 to
cefb054
Compare
|
👍 - LGTM |
rwjblue
added a commit
that referenced
this pull request
Jan 24, 2015
[BUGFIX beta] Fix broken unregisterWaiter semantics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember.Test.unregisterWaiter is supposed to unregister only the waiter that matches the arguments you pass it. Due to a bug it actually unregisters all waiters with the same context.