Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let View#appendChild instantiate SimpleBoundViews rather than doing it manually ourselves #10326

Merged
merged 1 commit into from
Feb 1, 2015

Conversation

ebryn
Copy link
Member

@ebryn ebryn commented Feb 1, 2015

This is a good idea because otherwise these SimpleBoundView instances go through the instance-based path in createChildViews and that ends up using setProperties to pass in the parentView and renderer.

@mmun

ebryn added a commit that referenced this pull request Feb 1, 2015
Let `View#appendChild` instantiate `SimpleBoundView`s rather than doing it manually ourselves
@ebryn ebryn merged commit 4b633e2 into emberjs:master Feb 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant