Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make meta.cache & meta.cacheMeta lazy #10350

Merged
merged 1 commit into from
Feb 4, 2015
Merged

Make meta.cache & meta.cacheMeta lazy #10350

merged 1 commit into from
Feb 4, 2015

Conversation

ebryn
Copy link
Member

@ebryn ebryn commented Feb 4, 2015

@stefanpenner
Copy link
Member

#'s please

@ebryn
Copy link
Member Author

ebryn commented Feb 4, 2015

@stefanpenner this isn't about macro performance, it's to prevent meta allocations for things like metal views that might not ever have cache/cacheMeta because they don't use computed properties

@ebryn
Copy link
Member Author

ebryn commented Feb 4, 2015

12% faster on Ember.Object.create benchmark in ember-performance

ebryn added a commit that referenced this pull request Feb 4, 2015
@ebryn
Merge pull request #10350 from ebryn/lazy-caches
4966110 
Make meta.cache & meta.cacheMeta lazy
@ebryn ebryn merged commit 4966110 into emberjs:master Feb 4, 2015
@fivetanley
Copy link
Member

yessss 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebryn @stefanpenner @fivetanley