[BUGFIX] Handle binding namespaced attributes (#9298) #10365
Conversation
|
Small clarification, this cannot be pulled into beta (since #10186 is only on master). Can you remove the |
|
No, I'm the one who was missing something. Will do. |
oneeman
changed the title
| run(function () { | ||
| view.set('xlinkHref', '/bar.png'); | ||
| }); | ||
| equal(view.$().attr('xlink:href'), '/bar.png', "namespaced attribute is updated"); |
There was a problem hiding this comment.
Don't know. Was going to try it out with an interactive saucelabs session just now, but both it and master stop with 0 of 3 assertions passed: http://imgur.com/rP5PVTA. I can try tonight to see if it's a problem with my set-up or if something needs to be fixed. IE 9 passes.
There was a problem hiding this comment.
We do something like the following in HTMLBars for setAttributeNS detection:
var doc = typeof document === 'undefined' ? false : document;
if (doc && doc.createElementNS) {
/* do stuff */
}That might work here?
There was a problem hiding this comment.
So I was using npm start instead of ember serve --environment=production. Did it again using the latter and all the tests in the module (including the one I added) pass in IE8.
|
@rwjblue I'd also like to land this into 1.11! |
[BUGFIX] Handle binding namespaced attributes (#9298)
Resolves #9298 as proposed in #10186 (comment).