Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusive morph #10413

Merged
merged 6 commits into from
Feb 12, 2015
Merged

Inclusive morph #10413

merged 6 commits into from
Feb 12, 2015

Conversation

krisselden
Copy link
Contributor

WIP to get working with inclusive morph refactor.

Most tests are fixed, when I run locally I have 10694 assertions of 10708 passed, 14 failed.

@mmun and @wycats

@rwjblue
Copy link
Member

rwjblue commented Feb 11, 2015

We are super early in the cycle, and inclusive morph fixes many bugs, should we land it in 1.11.0-beta.2?

@ebryn
Copy link
Member

ebryn commented Feb 11, 2015

I vote yes :)

ebryn added a commit that referenced this pull request Feb 12, 2015
@ebryn ebryn merged commit 9745ea5 into master Feb 12, 2015
@mmun mmun deleted the inclusive-morph branch February 12, 2015 01:40
@rwjblue
Copy link
Member

rwjblue commented Feb 15, 2015

I think including this in 1.11.0-beta.2 is very important. If we do not include it we will have to maintain two different rendering processes (HTMLBars 0.10 and 0.11+), and it would be nice to take advantage of the improvements being done in HTMLBars throughout the beta cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants