[BUGFIX release] Fix nested simple bindings inside of nested yields within views #10493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ebryn was this the source of that list-view issue? |
|
@stefanpenner yes, it manifested itself within a list view, but wasn't related to it |
|
this is a followup to #10489 |
ebryn
force-pushed
the
better-nested-yield-fix
branch
5 times, most recently
from
4085159 to
e766a2c
Compare
|
Travis + PhantomJS are trolling me so hard here. I've run these tests locally and all are passing. |
ebryn
force-pushed
the
better-nested-yield-fix
branch
from
e766a2c to
72efdae
Compare
|
Passing. @mmun a 👍 would be great. Looks sane to me. |
|
@ebryn unrelated but how Travis + PhantomJS trolling is fixed? |
|
@mmun already 👍ed this privately |
|
@quaertym just kept rerunning it |
mixonic
added a commit
that referenced
this pull request
Feb 20, 2015
[BUGFIX release] Fix nested simple bindings inside of nested yields within views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mmun @rwjblue