[BUGFIX canary] Prevent unknown input types from erroring. #10690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return type; | ||
| } | ||
|
|
||
| var input = document.createElement('input'); |
There was a problem hiding this comment.
we should likely just create this element once, not once per cache miss.
rwjblue
force-pushed
the
detect-input-type
branch
from
35cbe29 to
8d6b2f7
Compare
Browsers support various values for `type`, and generally auto-correct
to just `"text"` if an unknown type is set via standard HTML.
Unfortunately, the same auto-correct behavior does not apply when
setting the attribute directly, and in some circumstances throw an
error where the type is not valid.
Specifically, the following throws an error in IE10:
```javascript
var e = document.createElement('input');
e.type = 'search';
```
However the following HTML would auto-correct to `"text"`:
```html
<input type="search">
```
rwjblue
force-pushed
the
detect-input-type
branch
from
8d6b2f7 to
7526d1f
Compare
|
LGTM |
mixonic
added a commit
that referenced
this pull request
Mar 21, 2015
[BUGFIX canary] Prevent unknown input types from erroring.
|
Thanks Robert. |
|
@rwjblue I think this can actually be pulled out if tildeio/htmlbars#355 lands and input#type is added to the list of bad pairs to use |
|
C |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers support various values for
type, and generally auto-correct to just"text"if an unknown type is set via standard HTML.Unfortunately, the same auto-correct behavior does not apply when setting the attribute directly, and in some circumstances throw an error where the type is not valid.
Specifically, the following throws an error in IE10:
However the following HTML would auto-correct to
"text":This PR adds a feature detect to see if a given type can be set to
input. If setting the type results in the value, then we use it otherwise we default to"text".Fixes #10458.