isVisible fixes #10888
Merged
isVisible fixes #10888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple small additions got the isVisible tests passing.
The first change sets the initial style value based on the
isVisibleproperty. One potential problem with this is that if someone hasattributeBindingsfor style setup, thenisVisiblewill stomp on the style property withdisplay: nonewhen the component is rendered. However, whenisVisiblebecomes true, the style from attributeBindings is restored. Really one could argue that this isn't a problem, but I went ahead and added a test and a fix for this in the 3rd commit.Most of the "isVisible with Container" tests were failing because a view had a template method that returned a raw string. Adding an additional check for
layoutTemplate.rawbefore attempting to setupblockToRenderworked around this issue.