View attribute fixes #10957
Merged
View attribute fixes #10957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchlloyd
force-pushed
the
view-attr-fixes
branch
from
fa5d43d to
e6e0bf7
Compare
mitchlloyd
force-pushed
the
view-attr-fixes
branch
from
e6e0bf7 to
c278ff5
Compare
It seems that this test was passing in spirit: the number of observers does not increase when rerendering.
Interestingly, spaces are allowed when setting classNameBindings on a
view inside of a template.
{{view classNameBindings="prop:true:false anotherProp:more-true:more-false"}}
However, they are not allowed when setting the property on a view class:
Ember.View.create({
classNameBindings: 'prop:true:false anotherProp:more-true:more-false'
});
To handle both of these cases, we split the incoming classNameBindings
property by spaces when using the view keyword.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on remaining classNameBindings and attributeBindings failures.